[bugfix] Incorrect reference frame used in HD for WAMIT/WAMIT2 #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing strange results in a pitch free decay when a symmetric potential flow (WAMIT) body was rotated by 180 degrees.
|
Closes #914 |
jjonkman
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
I talked through this @andrew-platt and agree with this fix.
Codecov Report
@@ Coverage Diff @@
## dev #915 +/- ##
=======================================
Coverage 11.17% 11.17%
=======================================
Files 211 211
Lines 310636 310636
Branches 181311 181308 -3
=======================================
+ Hits 34719 34722 +3
Misses 231795 231795
+ Partials 44122 44119 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge
Bug description
An incorrect reference frame was applied to mesh used for the potential flow bodies when rotated using the
PtfmRefztRotinput in the main HydroDyn input file. This mesh reference orientation should have been set to the identity.@rdamiani found this bug in testing a proprietary floating platform design including both Morison and potential flow elements. He had noticed that rotating the
WAMITbody produced a different period in a pitch free decay test. It is expected that this frequency would be identical for an axisymmetricWAMITbody. See #914 for plots.For further testing, a very simple test using a purely potential flow (
WAMITbody) floating platform from the ITI Barge test case (5MW_ITIBarge_DLL_WTurb_WavesIrrregression test). Turning off waves and wind, a free decay test from -5 degrees initial pitch is performed.Before fix:
After bug fix:
Related issue, if one exists
#914
Impacted areas of the software
Potential flow (WAMIT) bodies in HydroDyn that are rotated will be affected. No regression tests currently exist using this feature.